Skip to content

[parquet] Add some tests to cover selective list child padding - #10258

Merged
Jefffrey merged 2 commits into
apache:mainfrom
alamb:codex/pr9848-coverage-tests
Jul 5, 2026
Merged

[parquet] Add some tests to cover selective list child padding#10258
Jefffrey merged 2 commits into
apache:mainfrom
alamb:codex/pr9848-coverage-tests

Conversation

@alamb

@alamb alamb commented Jul 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Draft as it includes #9848 from @HippoBaro as well

There were a few uncovered cases I found via code coverage, so this PR adds additional coverage

Changes:

  • Adds an ArrowWriter round-trip test for List with an item null, a null parent list, and a long string to exercise selective padding end to end.
  • Adds a short definition-level bitmap test that covers the unfiltered full-word append path.

@github-actions github-actions Bot added parquet Changes to the parquet crate arrow Changes to the arrow crate labels Jul 1, 2026
@alamb alamb mentioned this pull request Jul 1, 2026
Merged
@HippoBaro

HippoBaro commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Thank you for the improved coverage 🙇

@alamb
alamb force-pushed the codex/pr9848-coverage-tests branch from 37537f8 to 9110f09 Compare July 2, 2026 10:28
@github-actions github-actions Bot removed the arrow Changes to the arrow crate label Jul 2, 2026
@alamb
alamb force-pushed the codex/pr9848-coverage-tests branch from 9110f09 to 803fcbb Compare July 2, 2026 10:30
@alamb alamb changed the title [parquet] Cover selective list child padding [parquet] Add some tests to cover selective list child padding Jul 2, 2026
@alamb
alamb marked this pull request as ready for review July 2, 2026 10:50
@Jefffrey
Jefffrey merged commit 1583c8e into apache:main Jul 5, 2026
16 checks passed
@Jefffrey

Jefffrey commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

thanks @alamb & @HippoBaro

@Jefffrey Jefffrey added the development-process Related to development process of arrow-rs label Jul 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jefffrey Jefffrey Jefffrey approved these changes
+1 more reviewer
@HippoBaro HippoBaro HippoBaro approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

development-process Related to development process of arrow-rs parquet Changes to the parquet crate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alamb @HippoBaro @Jefffrey